Extract shared error helpers and add comprehensive test coverage#26
Merged
Extract shared error helpers and add comprehensive test coverage#26
Conversation
…and add comprehensive test coverage - Extract render_validation_error and render_error helpers into BaseController, replacing duplicated JSON error rendering across all shopkeeper controllers - Add comprehensive test coverage for all controller actions (happy + unhappy paths) - Add testing policy to CLAUDE.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_validation_errorandrender_errorhelpers intoBaseController, replacing duplicated JSON error rendering across all shopkeeper controllersTest plan
BaseControllertests forrender_validation_errorandrender_errorbin/rubocop- No lint errorsbin/brakeman- No security issuesbin/rails testto verify🤖 Generated with Claude Code